core icon indicating copy to clipboard operation
core copied to clipboard

Sharing without change permission should not show a rename button

Open jnweiger opened this issue 6 years ago • 4 comments

Testing web UI of 10.2.1RC3

User admin shares folder AdminPhotos with user jwtest with share, create, delete permissions, but without change permission:

image

User jwtest does not see a rename button on files within AdminPhotos (no change permisision, ok). But user jwtest has a rename button on subfolders within AdminPhotos.

image

Actually trying a rename results in an error then. This is inconsistent. Either always have the rename button and show errors, or never have the rename button.

jnweiger avatar Jul 03 '19 14:07 jnweiger

I guess jwtest also has read permission. Actually read+create+delete=>change in a logical sense. If I have read+create+delete and I want to:

  • change the name of a file, then download the file, delete the file on the server, rename the file locally, upload (create) the file on the server
  • change the content of an existing file, then delete the file on the server and upload a local file with different content

So IMO even being able to specify just read+create+delete without change is "odd"

phil-davis avatar Jul 03 '19 14:07 phil-davis

Yes, there seems to be an implicit read permission. The UI does not expose that to me, that is why I did not mention that.

I agree that (read+)delete+create should imply change for consistency with available workarounds. Although the workaround of delete+recreate has sideeffects, that an inplace change would not have: UUID changes, shares get dropped, ...

jnweiger avatar Jul 04 '19 11:07 jnweiger

Yes, the webUI always gives read priv. It has no UI for removing that.

phil-davis avatar Jul 04 '19 11:07 phil-davis

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 10 days if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Sep 19 '21 22:09 stale[bot]