client
client copied to clipboard
owncloud
sometimes oidc / oauth2 redirect URL port resets to 0
Pre-submission Checks
- [X] I checked for similar issues, but could not find any. I also checked the closed issues. I could not contribute additional information to any existing issue.
- [X] I will take the time to fill in all the required fields. I know that the bug report may be dismissed otherwise due to lack of information.
Describe the bug
Toying around with oidc I clicked "reopen browser" but the url that was produced started with http://127.0.0.1:0/?code=... ... which won't work when the browser tries to redirect to it.
Expected behavior
It should always use the random port of the localhost server.
Steps to reproduce the issue
I tried to reproduce this by restarting the idp several times and wiping its account tokens and sessions ... but I feel it is caused by the clients local server timing out?
Screenshots
No response
Logs
No response
Client version number
ownCloud 2.10.1 (build 7187) 82eefd Apr 5 2022 04:25:21 Libraries Qt 5.12.11, OpenSSL 1.1.1k 25 Mar 2021 verwenden das Virtual Files plugin: wincfapi windows-10.0.25136
Desktop environment (Linux only)
No response
Client package version and origin (Linux only)
No response
Installation path (Windows only)
C:\Program Files (x86)\ownCloud
Server information
ocis master
Additional context
No response
This issue was marked stale because it has been open for 30 days with no activity. Remove the stale label or comment or this will be closed in 7 days.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
@butonic usually this happens if you opened multiple auth windows, only one will succeed. If an error occurs during auth we will also restart the process so well start on a new port.
This issue was marked stale because it has been open for 30 days with no activity. Remove the stale label or comment or this will be closed in 7 days.
Nope. I'm fixing the case where the OAuth object goes into an error state and the URL is reset to an empty string. But I'll have a look.
See https://doc.qt.io/qt-6/qabstracthttpserver.html, we should replace our own implementation with a proper HTTP server. Obviously adds a dependency on #10701.