client icon indicating copy to clipboard operation
client copied to clipboard

macOS: change SOCKETAPI_TEAM_IDENTIFIER_PREFIX concatenation

Open erikjv opened this issue 4 years ago • 4 comments

Previously, the socket api prefix was created by concatenating SOCKETAPI_TEAM_IDENTIFIER_PREFIX and OC_APPLICATION_REV_DOMAIN together, so the first variable had to end in a "." to get the correct result. This change moves adding that period from configuration to the places where the concatenation happens.

erikjv avatar Nov 12 '21 13:11 erikjv

Downside is that we now probably require a value... I doubt that apple is fond of leading periods. On the other hand we will require signed builds for mac anyhow. At least when we build the shell extension or the fileprovider extension.

TheOneRing avatar Nov 12 '21 14:11 TheOneRing

I think we should wait with merging this one until the rest of #9209 is fixed.

erikjv avatar Nov 12 '21 14:11 erikjv

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar Nov 17 '21 14:11 sonarqubecloud[bot]

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar Mar 27 '22 19:03 sonarqubecloud[bot]