client icon indicating copy to clipboard operation
client copied to clipboard

Expose the use of VFS through the user-agent on PROPFINDs

Open SamuAlfageme opened this issue 2 years ago • 7 comments

In order to measure the adoption and rollout status of VFS as a feature, it'd be interesting to log those requests made by the client in a way they're easily identified.

The user-agent is a non-intrusive way of exposing this information on the server logs, without the need for the client to push it to a central service itself.

Since the sync client can support multiple accounts and each of them, several sync folders with one of the two modes enabled (either "classical" selective sync or VFS). I suggest a (vfs) suffix that could be included in the user-agent string to label these requests somehow. e.g.

192.168.1.56 - salfagem [20/Sep/2021:11:40:31 +0200] 
"PROPFIND /cernbox/desktop/remote.php/webdav/home/Pictures HTTP/1.1" 207 2045 "" "Mozilla/5.0 (Macintosh) mirall/2.9.0 (build 5137) (cernbox)"
[...]
192.168.1.56 - salfagem [20/Sep/2021:11:48:45 +0200] 
"PROPFIND /cernbox/desktop/remote.php/webdav/home/myLargeFiles HTTP/1.1" 207 4065 "" "Mozilla/5.0 (Macintosh) mirall/2.9.0 (build 5137) (cernbox) (vfs)"

Here, one can easily tell that the user is syncing the myLargeFiles folder à la VFS and Pictures in the old mode.

SamuAlfageme avatar Sep 20 '21 12:09 SamuAlfageme

Not that easy. We should rather look into support of https://api.kde.org/frameworks/kuserfeedback/html/index.html

TheOneRing avatar Sep 21 '21 15:09 TheOneRing

@TheOneRing looks very interesting and WFM as well as long as it's low interaction from the user PoV. Just to consent the submission/collection of data, of course.

SamuAlfageme avatar Sep 21 '21 15:09 SamuAlfageme

This issue was marked stale because it has been open for 30 days with no activity. Remove the stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Oct 22 '21 00:10 github-actions[bot]

The issue was marked as stale for 7 days and closed automatically.

github-actions[bot] avatar Oct 30 '21 00:10 github-actions[bot]

Reopening as still relevant to evaluate the user-adoption of VFS as feature

SamuAlfageme avatar Jun 27 '22 10:06 SamuAlfageme

This issue was marked stale because it has been open for 30 days with no activity. Remove the stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Jul 28 '22 00:07 github-actions[bot]

The issue was marked as stale for 7 days and closed automatically.

github-actions[bot] avatar Aug 05 '22 00:08 github-actions[bot]

This issue was marked stale because it has been open for 30 days with no activity. Remove the stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Sep 05 '22 00:09 github-actions[bot]

The issue was marked as stale for 7 days and closed automatically.

github-actions[bot] avatar Sep 13 '22 00:09 github-actions[bot]