client icon indicating copy to clipboard operation
client copied to clipboard

Spelling

Open jsoref opened this issue 4 years ago • 5 comments
trafficstars

This PR corrects misspellings identified by the check-spelling action.

The misspellings have been reported at https://github.com/jsoref/owncloud-client/commit/d234b5cb6721d9f59e44b52a964f43cae0d47937#commitcomment-56639815

The action reports that the changes in this PR would make it happy: https://github.com/jsoref/owncloud-client/commit/dc7338c826600fe31a05ddd0d6cb548b3f8815cc

Note: this PR does not include the action. If you're interested in running a spell check on every PR and push, that can be offered separately.

jsoref avatar Sep 17 '21 08:09 jsoref

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Sep 17 '21 08:09 CLAassistant

Woa sounds great and I'd love a spell checker action. I will need some time to check those. Note: Some of the files where auto generated to fixing the spelling in the changelog.md for example doesn't make much sense. I also saw some unrelated code style changes?

TheOneRing avatar Sep 17 '21 08:09 TheOneRing

Fwiw, this is what I used to ignore files: https://github.com/jsoref/owncloud-client/blob/spell-check/.github/actions/spelling/excludes.txt

Files that were ignored weren't checked for typos, and as long as I didn't make any mistakes, ignored files weren't changed either (beyond the linter changes which are really an entirely unrelated kettle of fish).

I specifically ignored ^changelog/[^/]*_ for this repository (but not some of the others), this may have been the wrong choice. It isn't terribly hard for me to unignore items, either. The spell checker uses fairly naive heuristics to suggest exclusions, and I generalize based on my experience w/ things, but I'm human and the spell-checker was written by me, so both stages can make mistakes.

If you can identify other files you don't want changed, it's trivial for me to add them to excludes and to drop their changes from this PR (or its relatives for the other owncloud repositories).

If there's an upstream for typos, feel free to identify them, I have an imaginary queue of things to check, and will happily add items to the queue, although I make no promises about when i'll get to items in it 😺.

jsoref avatar Sep 17 '21 09:09 jsoref

Results for GUI-tests https://drone.owncloud.com/owncloud/client/11261/5/1 :boom: The GUI tests failed. GUI Logs: (https://cache.owncloud.com/public/owncloud/client/11261/guiReportUpload/index.html) Server Logs: (https://cache.owncloud.com/public/owncloud/client/11261/guiReportUpload/serverlog.log)

ownclouders avatar Mar 27 '22 22:03 ownclouders

Results for GUI-tests https://drone.owncloud.com/owncloud/client/11728/6/1

:boom: The GUI tests failed.

GUI Logs: https://cache.owncloud.com/public/owncloud/client/11728/guiReportUpload/index.html

Server Logs: https://cache.owncloud.com/public/owncloud/client/11728/guiReportUpload/serverlog.log

Screenshots:

ownclouders avatar May 12 '22 06:05 ownclouders

outdated ...

DeepDiver1975 avatar Sep 25 '24 14:09 DeepDiver1975

Happy to update it if someone would look at it... it doesn't take me much time

jsoref avatar Sep 25 '24 14:09 jsoref

I guess I need to figure out how to update tests...

jsoref avatar Sep 25 '24 14:09 jsoref