client icon indicating copy to clipboard operation
client copied to clipboard

[UI] Add option to upload conflict files to the "Advanced" Settings

Open michaelstingl opened this issue 5 years ago • 8 comments

Capto_Capture 2020-08-17_07-19-38_PM copy

I'd like to try "default=on", at least in the 2.7.0-beta3.

We already have an Environment Variable for it: OWNCLOUD_UPLOAD_CONFLICT_FILES (Set to "1" to enable uploading conflict files to the server.)

michaelstingl avatar Aug 17 '20 17:08 michaelstingl

bool Capabilities::uploadConflictFiles() const
{
    static auto envIsSet = !qEnvironmentVariableIsEmpty("OWNCLOUD_UPLOAD_CONFLICT_FILES");
    static int envValue = qEnvironmentVariableIntValue("OWNCLOUD_UPLOAD_CONFLICT_FILES");
    if (envIsSet)
        return envValue != 0;

    return _capabilities[QStringLiteral("uploadConflictFiles")].toBool();
}

Seems to be a server setting, I guess we should coordinate with the server team?

TheOneRing avatar Aug 19 '20 11:08 TheOneRing

Seems to be a server setting, I guess we should coordinate with the server team?

Should be a server setting, but was never implemented.

michaelstingl avatar Aug 19 '20 11:08 michaelstingl

I see

TheOneRing avatar Aug 19 '20 12:08 TheOneRing

TODO: Investigate conflict file logic.

TheOneRing avatar Sep 08 '20 10:09 TheOneRing

Hello, may I ask what is the status of this feature, now that the sync client is v4+?

glpatcern avatar Jul 13 '23 09:07 glpatcern

Hello, may I ask what is the status of this feature, now that the sync client is v4+?

The latest implementation didn't work, so it was dropped:

  • https://github.com/owncloud/client/pull/8986#issuecomment-953708676

michaelstingl avatar Jul 13 '23 10:07 michaelstingl

The latest implementation didn't work, so it was dropped:

Thanks Michael for the quick reaction. That implementation was from 2 years ago, what about current plans?

glpatcern avatar Jul 13 '23 10:07 glpatcern

No plans currently

michaelstingl avatar Jul 13 '23 10:07 michaelstingl