client icon indicating copy to clipboard operation
client copied to clipboard

In case the graph endpoint is returning multiple personal spaces - we should really use the drive name

Open DeepDiver1975 opened this issue 1 year ago • 4 comments

https://github.com/owncloud/client/blob/e51dce78e143681585b69f8d637839d5762e9f02/src/libsync/graphapi/space.cpp#L101

DeepDiver1975 avatar Oct 22 '24 17:10 DeepDiver1975

Ocis has only one personal drive and doesn't provide a useful name.

TheOneRing avatar Oct 22 '24 17:10 TheOneRing

if (_drive.getDriveType() == personalC && _drive.getDriveType().isNotUseful()) {
    return tr("Personal");
}

DeepDiver1975 avatar Oct 22 '24 17:10 DeepDiver1975

How does the ocis response look like for personal folders?

DeepDiver1975 avatar Oct 22 '24 17:10 DeepDiver1975

ios has the same issue - and I assume android will as well

Proposal: add capability to identify if multiple personal spaces are supported by the backend (like kiteworks) or not like ocis In case the property is not set it is to be interpreted as false

        "spaces": {
          "version": "0.0.1",
          "enabled": true,
          "has_multiple_personal_spaces": true
        }

DeepDiver1975 avatar Oct 23 '24 09:10 DeepDiver1975