client icon indicating copy to clipboard operation
client copied to clipboard

[Spaces] Use thumbnails instead of the actual space image

Open michaelstingl opened this issue 2 years ago • 5 comments

Pre-submission Checks

  • [X] I checked for similar issues, but could not find any. I also checked the closed issues. I could not contribute additional information to any existing issue.
  • [X] I will take the time to fill in all the required fields. I know that the bug report may be dismissed otherwise due to lack of information.

Describe the bug

Space images with orientation flag stored in EXIF data aren't displayed in correct orientation.

Expected behavior

Space images with orientation flag stored in EXIF data should be displayed in correct orientation.

Steps to reproduce the issue

  1. Login admin:[email protected] in web UI and add test images from https://github.com/recurser/exif-orientation-examples to Space
  2. Setup same account in desktop sync client

Screenshots

CleanShot 2023-11-28 at 19 15 01@2x CleanShot 2023-11-28 at 19 15 09@2x

Logs

No response

Client version number

testpilotcloud 6.0.0.12730-daily20231128 e2a986
Libraries Qt 6.6.0, OpenSSL 3.1.4 24 Oct 2023
Using virtual files plugin: suffix
OS: macos-23.1.0 (build arch: arm64, CPU arch: arm64)
QPA: cocoa

Desktop environment (Linux only)

No response

Client package version and origin (Linux only)

No response

Installation path (Windows only)

No response

Server information

https://ocis.ocis-traefik.latest.owncloud.works/

[Log]  ownCloud Web UI 8.0.0-alpha.10  (index.html-LqZ16May.mjs, line 1)
[Log]  Infinite Scale 5.0.0-alpha.3+ad06a192d Community  (index.html-LqZ16May.mjs, line 1)

Additional context

Related?

  • https://github.com/owncloud/ocis/issues/4477

michaelstingl avatar Nov 28 '23 18:11 michaelstingl

What file do we download, an exif image or a png, if a png I'd say its the server issue.

TheOneRing avatar Nov 29 '23 11:11 TheOneRing

What file do we download, an exif image or a png, if a png I'd say its the server issue.

JPEG Image, with metadata in EXIF format (Portrait_7.jpg)

michaelstingl avatar Nov 29 '23 11:11 michaelstingl

https://bugreports.qt.io/browse/QTBUG-9414 Apparently we need to handle the rotation ourselves. I suggest we start using the thumbnail service as it solves a multitude of issues.

TheOneRing avatar Nov 29 '23 11:11 TheOneRing

I suggest we start using the thumbnail service as it solves a multitude of issues.

Works for me 👍 Maybe align thumbnail parameters with the Android implementation.

michaelstingl avatar Nov 29 '23 11:11 michaelstingl

I extended the docs a bit:

  • https://github.com/owncloud/ocis/pull/7853
  • https://owncloud.dev/services/thumbnails/#thumbnail-query-string-parameters

michaelstingl avatar Dec 05 '23 10:12 michaelstingl