Extend "restart required" dialog to Windows

[nicholas-wilson-au]

Pre-submission Checks

• [X] I checked for similar issues, but could not find any. I also checked the closed issues. I could not contribute additional information to any existing issue.
• [X] I will take the time to fill in all the required fields. I know that the bug report may be dismissed otherwise due to lack of information.

Describe the bug

I am getting an ownCloud notification when I log in to my PC that there is an update available and that I should restart the client to start the update. However, restarting the client nor restarting the PC results in the update starting.

Expected behavior

I expect that after closing the program, I should get a UAC request in windows to allow the updater to run.

Steps to reproduce the issue

Start the owncloud client. Get the pop up. right click on the owncloud client taskbar tray icon and select quit owncloud. Wait.

Screenshots

https://cloud.owncloud.com/s/mFEXiz1bCBku780

Logs

https://cloud.owncloud.com/s/k4hSM1oadCTx8K0

Client version number

4.0.10896

Desktop environment (Linux only)

No response

Client package version and origin (Linux only)

No response

Installation path (Windows only)

c:\program files\owncloud\owncloud.exe

Server information

cloud.owncloud.com

Additional context

For reference, while collecting the system information and unrelated program, Notepad++, showed an upgrade was available and its behavior was as expected.

[michaelstingl]

This notification isn't really actionable:

Restart needs to be performed from the Settings screen:

Then it successfully updates:

[TheOneRing]

Yes we still just emit the equivalent of balloon notifications... https://github.com/owncloud/client/issues/7552

[michaelstingl]

Notepad++, showed an upgrade was available and its behavior was as expected.

Notepad++ shows own update pop-up, not the native Win notification:

[michaelstingl]

Yes we still just emit the equivalent of balloon notifications... #7552

Could a click on the Win balloon notification open the Settings screen?

[TheOneRing]

Not on Windows https://doc.qt.io/qt-6/qsystemtrayicon.html#messageClicked . I'd suggest to implement notifications for Windows. Luckily I'm maintaining a project for that xD

[github-actions[bot]]

This issue was marked stale because it has been open for 30 days with no activity. Remove the stale label or comment or this will be closed in 7 days.

[github-actions[bot]]

The issue was marked as stale for 7 days and closed automatically.

[TheOneRing]

Implement a dialogue like mentioned in https://github.com/owncloud/client/issues/10980#issuecomment-1620198377

[rpausch-owncloud]

I ran in the very same problem. I manually closed the owncloud client and reopened it: Nothing happened.

The button "Restart & update" is hidden at the bottom of the ownCloud Client Window.

[saw-jan]

Tested with ownCloud 6.0.0..13174-daily20240121 [ab204c]

But clicking Restart now button closes the client but doesn't restart it :x: Log: ownCloud.log

CC @TheOneRing

[saw-jan]

Tested on ownCloud-6.0.0.13577-daily20240325

• Clicking Restart now restarts the client :heavy_check_mark:
• The dialog appears again and update doesn't start :x:

[erikjv]

@saw-jan How was the client started? Did it have command-line options?

Note to myself and @TheOneRing : we do not check for updates after start-up if the user tried to open a file or if the settings dialog is requested through the cmdline. And with a restart, we pass these options along again.

[saw-jan]

Tested with ownCloud-6.0.0.14181-daily20240709-x86_64.AppImage, the update is downloaded and Restart now button restarts the client. :heavy_check_mark:

How was the client started? Did it have command-line options?

I just ran ./ownCloud-6.0.0.14181-daily20240709-x86_64.AppImage in the terminal

[saw-jan]

The restart works now.

[TheOneRing]

@saw-jan How was the client started? Did it have command-line options?

Note to myself and @TheOneRing : we do not check for updates after start-up if the user tried to open a file or if the settings dialog is requested through the cmdline. And with a restart, we pass these options along again.

Can you please open an issue?