client icon indicating copy to clipboard operation
client copied to clipboard

[QA] Mac: Can't quit the client from Dock when Wizard is open

Open HanaGemela opened this issue 2 years ago • 7 comments

Pre-submission Checks

  • [X] I checked for similar issues, but could not find any. I also checked the closed issues. I could not contribute additional information to any existing issue.
  • [X] I will take the time to fill in all the required fields. I know that the bug report may be dismissed otherwise due to lack of information.

Describe the QA issue

Can't quit the client from Dock when Wizard is open Client 3.1.0 mac 13.2

Steps to reproduce the issue

  1. Click 'Add account' in GUI
  2. Right click on the ownCloud icon in Dock
  3. Quit

Screenshots

Image

No screenshot

Expected behavior

User can quit the client

Actual behavior

Client remains running

HanaGemela avatar Feb 07 '23 18:02 HanaGemela

It's kind of what you requested when you complained that you could abort the wizard by accident.

TheOneRing avatar Feb 07 '23 18:02 TheOneRing

image

Works as designed. When we have open dialogs on mac the menu is disabled.

TheOneRing avatar Feb 08 '23 11:02 TheOneRing

Then after clicking quit from the Dock, user should be asked if he really wants to cancel account setup

HanaGemela avatar Feb 08 '23 11:02 HanaGemela

I couldn't event click quit as the menu is disabled. See screenshot.

TheOneRing avatar Feb 08 '23 11:02 TheOneRing

I meant the icons at the bottom of the screen

HanaGemela avatar Feb 08 '23 12:02 HanaGemela

@erikjv I guess we should be able to receive the signal and bring the client to the front?

TheOneRing avatar Feb 08 '23 12:02 TheOneRing

macOS actually sends an expose event, not a quit/close event. With Qt 6.4, the window gets raised, but not over the active application (unless it's the Finder). I'm not sure if the not-raising-over-active-application is a macOS policy, but in Qt 6.5 dialogs are implemented using native dialogs, so the behaviour there might be different/better.

So we should re-test this with Qt 6.5

erikjv avatar Jun 16 '23 15:06 erikjv