client
client copied to clipboard
owncloud
[Spaces] Separate Spaces from Personal Files and Shares
Pre-submission Checks
- [X] I checked for similar issues, but could not find any. I also checked the closed issues. I could not contribute additional information to any existing issue.
- [X] I will take the time to fill in all the required fields. I know that the bug report may be dismissed otherwise due to lack of information.
Feature description
On the account page, it would be nice, to have Personal Files and Shares on top, then all your spaces below, with some visual separation.
Proposed solution
See current iOS implementation for inspiration:
Alternative solutions you considered
No response
Additional context
Current state:
testpilotcloud 3.0.0.8351-daily20220818 804d66 Aug 18 2022 02:40:12
Libraries Qt 5.15.5, OpenSSL 1.1.1q 5 Jul 2022
Using virtual files plugin: suffix
osx-21.6.0
This issue was marked stale because it has been open for 30 days with no activity. Remove the stale label or comment or this will be closed in 7 days.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
This has to be done after https://github.com/owncloud/client/pull/10224 goes in, it's in the same code.
First attempt can be seen in https://github.com/owncloud/client/pull/10265
List views on iOS support grouping, while Qt does not. One option is to add a separator item, but that would complicate the underlying model code even more. Another option is to sort the "personal" and "shared" spaces into different items in a treeview, but this would be a big change to the underlying model, the views, and the painting code. We thing that complicating this code is a good idea, on the contrary: we are simplifying it by moving the "Add" button out of the list and into the surrounding dialog.
So I would propose to take the simple route: just add an extra text label for shared spaces. See the "(Shared)" text in the screenshot below.
Looks sorting not properly working:
testpilotcloud 4.0.0.10074-daily20230209 6ba0a9
Libraries Qt 5.15.8, OpenSSL 1.1.1t 7 Feb 2023
Using virtual files plugin: suffix
osx-22.2.0
New issue:
- https://github.com/owncloud/client/issues/10501
Proposal was, to use different icons:
 |
 |
|---|
Personal
- http://ocis.ocis-traefik.latest.owncloud.works/icons/resource-type-folder-fill.svg
Shares
- http://ocis.ocis-traefik.latest.owncloud.works/icons/share-forward-fill.svg
Project Spaces
- http://ocis.ocis-traefik.latest.owncloud.works/icons/layout-grid-fill.svg (or Space image thumbnail)
Default icons Gould be retrieved from theme.json
- https://github.com/owncloud/web/issues/8424
@fmoc already separated the overlay status icons
/cc @TheOneRing
Proposal from @TheOneRing :
- Graph API Drives endpoint should respond with a default image, if no Space image is set.
Alternatively the web fronted should set a default image if none is set by the user.
Is using a default icon an option as well? I.e. space returns the icon name from the remixicon icon set. Could be used by all clients then if no space image is set.
Is using a default icon an option as well? I.e. space returns the icon name from the
remixiconicon set. Could be used by all clients then if no space image is set.
Is that icon available in the new branding endpoint? Or are you suggesting to start a shared resources initiative?
Icons look all the same in ownCloud 4.0.0.10645-daily20230414, mac
Works as designed ✅
Backend need to provide different icons:
- https://github.com/owncloud/ocis/issues/5895
Currently you only see different icons when you upload a Space image.
Wouldn't it be nice to crop the images the same way server does? (I'm not saying the server approach is the correct one, just that both of them should be the same)
@michaelstingl confirmed that it works as designed. Client displays what server provides