client icon indicating copy to clipboard operation
client copied to clipboard

Allow user to retry OAuth2/OIDC login

Open fmoc opened this issue 1 year ago • 1 comments

screenshot_2022-08-16_10-48-33 screenshot_2022-08-16_10-49-05 screenshot_2022-08-16_10-49-12

I'm sure this could and should be polished. We are going to work on these widgets soon again when integrating them into the wizard, which is a good chance to improve the UX.

fmoc avatar Aug 16 '22 09:08 fmoc

Maybe we should move the icon to the top left? Especially when the error is displayed it looks like its not aligned to anything?

TheOneRing avatar Aug 17 '22 12:08 TheOneRing

WIP in an upcoming PR. This just adds the retry functionality.

fmoc avatar Aug 19 '22 14:08 fmoc

Sadly the change is so outdated that I can't take over the development...

TheOneRing avatar Sep 22 '22 09:09 TheOneRing

I was able to eliminate the hack due to some overall changes in the design of the dialog. Please review again.

fmoc avatar Oct 06 '22 10:10 fmoc

Results for GUI-tests https://drone.owncloud.com/owncloud/client/13373/6/1

:boom: The GUI tests failed.

GUI Logs: https://cache.owncloud.com/public/owncloud/client/13373/guiReportUpload/index.html

Server Logs: https://cache.owncloud.com/public/owncloud/client/13373/guiReportUpload/serverlog.log

Screenshots:

ownclouders avatar Oct 06 '22 10:10 ownclouders

Need to rebase this PR on https://github.com/owncloud/client/pull/10176, which fixes a couple of problems.

fmoc avatar Oct 10 '22 16:10 fmoc

screenshot_2022-10-11_17-31-30

Had to start over, but I managed to bring it into a usable state. Still investigating why the error label uses this much vertical space (Qt won't let me shrink it vertically during runtime at this point).

fmoc avatar Oct 11 '22 15:10 fmoc