calendar icon indicating copy to clipboard operation
calendar copied to clipboard

Published 20 hours ago • verified publisher icon owncloud

get rid of jQuery UI

Open georgehrke opened this issue 9 years ago • 13 comments

related to https://github.com/owncloud/core/issues/18739

georgehrke avatar Sep 05 '15 13:09 georgehrke

besides the dialog we also use a timepicker that requires jQuery UI.

@raghunayyar @jancborchardt Do you know of any good alternatives?

georgehrke avatar Jan 14 '16 11:01 georgehrke

Can we simply use that part of jQuery UI? Or is the whole lib always needed?

cc @owncloud/designers do you know of any modern good timepicker library which also work on mobile?

jancborchardt avatar Jan 14 '16 18:01 jancborchardt

Can we simply use that part of jQuery UI? Or is the whole lib always needed?

It requires jQuery UI core (whatever that is) https://github.com/owncloud/calendar-rework/blob/master/js/vendor/jquery-timepicker/README.md#requirements

georgehrke avatar Jan 15 '16 11:01 georgehrke

the jQuery UI dialogs are completely gone by now. The only thing left are the date and the time picker.

georgehrke avatar Feb 17 '16 15:02 georgehrke

The core issue was rescheduled to ownCloud 9.1 This leaves us plenty of time here. Postponing here as well.

georgehrke avatar Feb 17 '16 15:02 georgehrke

Awesome, I will find an ng replacement for them this weekend.

raghunayyar avatar Feb 19 '16 05:02 raghunayyar

Moving to 1.4, which will probably be our release to support 9.1

georgehrke avatar May 10 '16 13:05 georgehrke

@jancborchardt What are the plans on the nextcloud side to drop jQuery UI?

georgehrke avatar Aug 14 '16 12:08 georgehrke

Let’s see where we still use it:

  • LDAP settings: we can move away from the tab-based layout now that the settings are split into individual pages. cc @blizzz
  • The modal for the filepicker. Maybe we can just use that part.
  • The modal for accepting remote shares: Moved to the notifications area. cc @nickvergessen @schiessle
  • The Calendar app here.

Anything else I forgot? I would say we should get rid of it step by step. We can use individual aspects of it if we want, but maybe it is better to use the relevant components from Bootstrap instead as we already do with tipsy/tooltip.js

jancborchardt avatar Aug 24 '16 13:08 jancborchardt

The modal for accepting remote shares

It's still used as a fallback, when notifications app is not enabled.

nickvergessen avatar Aug 24 '16 15:08 nickvergessen

Instead of that as fallback, could we use the notification up top? @nickvergessen

jancborchardt avatar Aug 25 '16 08:08 jancborchardt

LDAP settings: we can move away from the tab-based layout now that the settings are split into individual pages. cc @blizzz

We can talk about whether and how to change the layout. If it requires heavier changes, it's likely that it would slip to Nc 12. Anyway, the calendar repo is not the best place to track this…

blizzz avatar Aug 26 '16 21:08 blizzz

@blizzz see https://github.com/nextcloud/server/issues/1090 for the server issue

jancborchardt avatar Aug 26 '16 22:08 jancborchardt