[a11y] 11.1.4.3 Contrast (minimum)
Related Issues
App:
- [x] Add changelog files for the fixed issues in folder changelog/unreleased. More info here
- [x] Add feature to Release Notes in
ReleaseNotesViewModel.ktcreating a newReleaseNote()with String resources (if required)
QA
Everything related to the toolbar will be done in this issue: https://github.com/owncloud/android/issues/4365.
The list_item_lastmod_and_filesize_text color has been changed to meet minimum contrast requirements. Apart from the places that it says in the issue, it has also been changed in:
- Log list (subtitle): Log size
- Transfer list (subtitles and icons)
- Subtitle bottom sheet file
- Receive external files: The subtitle of the items when a folder is chosen to upload
In addition, the share_warning_text color has been modified to meet with minimum contrast requirements. This text color is visible in the warning of public links and the text color has also been changed in:
- Files folder picker:
You do not have permission to add content here!text - Choose upload folder:
You do not have permission to add content here!text
FYI @jesmrec @JuancaG05
The list_item_lastmod_and_filesize_text color have been changed for this hex value #707575 to meet with the requirements:
Also we have created a new color share_warning_text (#525757) for public link warning description to meet the requirements:
Contrast checked used: https://webaim.org/resources/contrastchecker/
QA checks:
date and size in list of files
Contrast: #707575 vs #FFFFFF ➡️ 4.68 > 4.50 ✅
drawer footer (quota)
Contrast: #707575 vs #FFFFFF ➡️ 4.68 > 4.50 ✅
land-drawer footer (quota)
Contrast: #707575 vs #FFFFFF ➡️ 4.68 > 4.50 ✅
list footer (#files & #folders)
Contrast: #707575 vs #FFFFFF ➡️ 4.68 > 4.50 ✅
shared file size
Contrast: #707575 vs #FFFFFF ➡️ 4.68 > 4.50 ✅
warning public link
Contrast: #525757 vs #E0E0E0 ➡️ 5.56 > 4.50 ✅
expiration date in public link
Contrast: #707575 vs #FFFFFF ➡️ 4.68 > 4.50 ✅
folder picker - target folder with no writing permissions
Contrast: #525757 vs #E0E0E0 ➡️ 5.56 > 4.50 ✅
folder picker - share from 3rd party app to folder with no writing permissions
Contrast: #525757 vs #E0E0E0 ➡️ 5.56 > 4.50 ✅
log size
Contrast: #707575 vs #FFFFFF ➡️ 4.68 > 4.50 ✅
upload list: status, size, date, account, space and target folder
Contrast: #707575 vs #FFFFFF ➡️ 4.68 > 4.50 ✅
bottom sheet: date and size
Contrast: #707575 vs #FFFFFF ➡️ 4.68 > 4.50 ✅
tested all views in portrait/landscape orientation.
Also, i took a look to the high contrast mode, which look is much better than before. Moving forward an accessible app step by step 💯
This is approved from my side.