android icon indicating copy to clipboard operation
android copied to clipboard

[TECHNICAL] Rely on `resharing` capability for oCIS accounts

Open JuancaG05 opened this issue 1 year ago • 5 comments

Currently, to know whether we should show the share button or not, we rely on the R permission of the file AND the resharing capability. The resharing capability has been set to false by default in oCIS servers (https://github.com/owncloud/ocis/issues/8842), so we shouldn't look at it anymore. There can be the case in which some files in the Shares space come with the R permission, but none of them should be resharable. So, several acceptance criteria here:

  • [ ] Keep the same behaviour as now in oC10 servers
  • [ ] Rely only on resharing capability in oCIS servers
  • [ ] Never show the share button in the Shares space (only available in oCIS)

TASKS

  • [ ] Research (if needed)
  • [ ] Create branch technical/remove_resharing_capability_ocis
  • [ ] Development tasks
    • [ ] Implement whatever
    • [ ] ...
    • [ ] Implement unit tests (if needed)
  • [ ] Code review and apply changes requested
  • [ ] Design test plan
  • [ ] QA
  • [ ] Merge branch feature/remove_resharing_capability_ocis into master

JuancaG05 avatar May 03 '24 08:05 JuancaG05

Correction: The code enabling resharing for the share jail was removed. The capability will always be false. Our main concern is to disable resharing for the sharejail in any case. Files in the sharejail might provide the R permission but we should never offer the option to share them.

TheOneRing avatar May 03 '24 08:05 TheOneRing

iOS related: https://github.com/owncloud/ios-app/issues/1353

jesmrec avatar May 03 '24 12:05 jesmrec

Follow up: https://github.com/owncloud/ocis/issues/9681

jesmrec avatar Aug 01 '24 07:08 jesmrec

Rolling version not following the R: propfinded items with R are not allowed to be reshared.

jesmrec avatar Aug 01 '24 07:08 jesmrec

Update: https://github.com/owncloud/ocis/issues/9681#issuecomment-2286133775

R does not mean resharing. We have to mind the capability.

If capability is false (as it is expected in oCIS servers from now on):

  • The share permission should be removed from default in private shares (now, it is 31)
  • The Can Share permission should be gone or disabled in the sharing dialog

jesmrec avatar Aug 13 '24 12:08 jesmrec