android icon indicating copy to clipboard operation
android copied to clipboard

[BUG] Cancel sync actions does not work

Open fpauser opened this issue 2 years ago • 7 comments

Actual behaviour

Synchronizing an offline folder cannot be canceled. The action "Synchronisation abbrechen" is displayed when clicking the 3-point menu on the folder, but clicking it only closes the menu and does not cancel the sync.

Expected behaviour

The sync should stop when clicking "Synchronisation abbrechen".

Steps to reproduce

Mark a folder with many files as offline available. Let it sync and try to cancel the sync while the sync is running.

Can this problem be reproduced with the official owncloud server? Nope.

Environment data

Android version: 13

Device model: Galaxy Tab S8 5G

Stock or customized system:-

ownCloud app version: 4.1.1

ownCloud server version: 4.0.2

fpauser avatar Oct 27 '23 09:10 fpauser

Hi @fpauser! Thanks for opening a new issue!

You say it is not reproducible with the demo server or you didn't try? In such case, could you provide us with some test credentials in your server to check this? Some logs would be also very useful. You can send all of this to keep privacy to [email protected] and we'll work on it 😺

JuancaG05 avatar Oct 27 '23 09:10 JuancaG05

Hi @JuancaG05, I'll create an account and give you access to the server. Credentials coming via E-Mail.

fpauser avatar Oct 27 '23 09:10 fpauser

offline folder you mean downloaded or available offline? Av offline folders are intended to be always synced. If they are not synced, they are not av. offline. So, this is the expected behaviour.

In case of "downloaded", sync actions are asynchronous, that means, if they are triggered and run on its own. An example: syncing a folder with 100 files: new workers to sync the file are created in background, if you click on "cancel" when 50 are created, those 50 goes on, no matter if you cancelled. Only the ones that are not triggered will be cancelled.

On the other hand, it's pretty useful for us to have descriptive titles on the new issues. Let me modify it, and in future issues you create and add the title that better describes the problem you got.

jesmrec avatar Oct 27 '23 09:10 jesmrec

I mean a folder marked offline. The client seems to always sync and never finish. Thats why I tryed to stop the currently running sync and try to resync.

fpauser avatar Oct 27 '23 09:10 fpauser

Could be related:

https://github.com/owncloud/android/issues/4197

jesmrec avatar Oct 27 '23 11:10 jesmrec

#4197 could be the reason indeed. It would be nice if the android app could also log out its current activities, like the desktop app does. This would allow for a better understanding of what the app is doing.

fpauser avatar Oct 27 '23 11:10 fpauser

You are totally right. We'll try to schedule this one in the shorter term.

jesmrec avatar Oct 27 '23 12:10 jesmrec