[FEATURE REQUEST] Open deeplinks in app, items already discovered (1st round)

[jesmrec]

Private links generated by the server, must be opened inside the oC Android app.

This is a first approach with specific ACs:

• ~~App matching the host to be opened when private link is clicked. Not needed to brand this. Static.~~
• ~~Working in only one account mode~~
• ~~If the link points to a file, the file will be downloaded/displayed~~
• ~~If the link points to a folder, the folder content will be displayed~~
• ~~If a locking method is set up, the file/folder will be displayed after unlocking~~
• If device does not have connection but the file is already downloaded, file is displayed
• ~~If device does not have connection but the folder is already discovered, content is displayed~~
• ~~If the file/folder is not reachable, app is opened and error is shown (toast/snackbar/...)~~
• ~~If no accounts are attached in the app, app is opened and error is shown (toast/snackbar/...) (feasible?)~~

Additional checks:

• ~~Lack of URL in the scheme (or *) are valid as well.~~

TASKS

• [x] Research (if needed)
• [x] Create branch feature/deep_links
• [x] Development tasks
  • [x] Implement intent-filter and launch it throught adb's command.
  • [x] App matching the host to be opened when private link is clicked. Not needed to brand this. Static.
  • [x] If no accounts are attached in the app, app is opened and error is shown in toast
  • [x] If the file/folder is not reachable, app is opened and error is shown (toast/snackbar/...)
  • [x] If a locking method is set up, the file/folder will be displayed after unlocking
  • [x] Working in only one account mode
  • [x] If device does not have connection but the folder is already discovered, content is displayed
  • [x] Lack of URL in the scheme (or *) are valid as well.
  • [x] If the link points to a folder, the folder content will be displayed
  • [x] If the link points to a file, the file will be downloaded/displayed
• [ ] Code review and apply changes requested
• [ ] Design test plan
• [ ] QA
• [ ] Merge branch feature/feature_name into master

PR

• App #3598
• Library (if needed)

[fesave]

Hi @tbsbdr!!!! We need to add some new action buttons to the detail screen and here we post three proposals that we have designed. what do you think about it? New ideas or contributions are welcome!!!!

cc @michaelstingl @abelgardep @jesmrec @theScrabi @davcres

Options

First Option	Second Option	Third Option

[michaelstingl]

Did you consider "Open in…" / "Open with…" instead of "Send" ? What do others do?

[fesave]

Did you consider "Open in…" / "Open with…" instead of "Send" ? What do others do?

The download button would change the text to "Open in..." or "Open with..." once the file has been downloaded. What do you think?

[jesmrec]

2nd one is awful for me

The download button would change the text to "Open in..." or "Open with..." once the file has been downloaded. What do you think?

i guess, depending on the openability of the file, right?

[tbsbdr]

shot from the hip:

• left aligned with icons
• style: some "secondary" (= more decent) button style if something like this exists in the android app. (currently i see 3 "primary" actions which is quite loud in my perception. )

Scribble:

known patterns / examples from other apps:

[fesave]

Hi @dragotin , @michl19 👋🏻 The First feature we should discuss!!!

As a result of last Monday's meeting, we have developed a solution to the problem of the deep link discussed that day.

As we can see in the first video, if the user clicks on the thumbnail (not applicable to video files), the image is downloaded and previewed, and the following times (as it is already downloaded) it will only be previewed. But we think it is an easter egg for the user because there is nothing to tell him if he clicks on the thumbnail he will be able to see it in detail.

https://user-images.githubusercontent.com/49989790/165295580-628aa6df-3d8d-4a4f-bd9a-2dd64a87d374.mp4

The second video I attach is a solution to the previous problem, the button is not final and is subject to changes in design and text.

https://user-images.githubusercontent.com/49989790/165295614-af97a9c3-8565-419e-96f3-6f9197d1652b.mp4

We would like to know what you think about it and what solution you like the most. Thanks!

cc @abelgardep @jesmrec @davcres

[dragotin]

I think both solutions are pretty good, but I would prefer the first one. I think it is clear nowadays that clicking on a thumbnail opens the file. But ... @tbsbdr will have an opinion ;-)