Check Android Lint Warnings

[jesmrec]

Lint step is executed in CI system over the code to assure correctness.

Currently, lint in CI is working fine but returning a bunch of warnings. We should review this warnings

TASKS

• [ ] Research (if needed)
• [ ] Create branch feature/feature_name
• [ ] Development tasks
  • [ ] Implement whatever
  • [ ] ...
• [ ] Code review and apply changes requested
• [ ] Design test plan
• [ ] QA
• [ ] Merge branch feature/feature_name into master

PR

• App
• Library (if needed)

[abelgardep]

I have modified the workflow in bitrise, so the lint will be executed just for the release variant, excluding debug. It reduces around 2 minutes the time required.

Anyway, we need to take a look at the lint errors and fix most of them.

[hannesa2]

Btw, on CI there is probably no ktLint or check task run, because I run into ktLint errors https://github.com/hannesa2/owncloud-android/pull/79/checks?check_run_id=2637502991

This is the disadvantage of your CI. Only you can change it, and when you don't do it, the afford here is pointless

[michaelstingl]

This is the disadvantage of your CI. Only you can change it, and when you don't do it, the afford here is pointless

@abelgardep @theScrabi Adding bitrise.yml to the repo, so everyone can propose changes with a pull request?

More information:

• https://devcenter.bitrise.io/builds/bitrise-yml-online/
• https://devcenter.bitrise.io/bitrise-cli/basics-of-bitrise-yml/

[abelgardep]

Btw, on CI there is probably no ktLint or check task run, because I run into ktLint errors

Ok, I see. I will add it. I tested that the ktLint run in the library build, but I forgot to add it in the app build. Good catch, thanks!

@abelgardep @theScrabi Adding bitrise.yml to the repo, so everyone can propose changes with a pull request?

At the moment anyone can see the bitrise.yml, but they can not propose changes. So, adding it to the repository could be a good addition, we will check it 👍

[jesmrec]

LEt's use this one for the lint refinement, and a new one for the bitrise.yml export -> https://github.com/owncloud/android/issues/3252