android icon indicating copy to clipboard operation
android copied to clipboard

Proposal to fix provider

Open hannesa2 opened this issue 4 years ago • 3 comments

It's a proposal to fix conflicting provider form logging lib https://github.com/owncloud/android-library/pull/379 It simply accept the provider from ownCloud

hannesa2 avatar Apr 06 '21 07:04 hannesa2

Thanks for the fix.

In the code review, take in account this: https://github.com/owncloud/android-library/pull/379#issuecomment-813882502 @theScrabi @abelgardep @JuancaG05

jesmrec avatar Apr 08 '21 10:04 jesmrec

Hi @hannesa2, this solution does not fix the problem completely. Yes, we can build the app now, but it crashes when we try to share the logs. Could you take a look? Thanks!

    Process: com.owncloud.android, PID: 29054
    java.lang.IllegalArgumentException: Couldn't find meta-data for provider with authority com.owncloud.android.provider
        at androidx.core.content.FileProvider.parsePathStrategy(FileProvider.java:606)
        at androidx.core.content.FileProvider.getPathStrategy(FileProvider.java:579)
        at androidx.core.content.FileProvider.getUriForFile(FileProvider.java:417)
        at info.hannes.logcat.base.LogBaseFragment.sendLogContent(LogBaseFragment.kt:229)
        at info.hannes.logcat.base.LogBaseFragment.onOptionsItemSelected(LogBaseFragment.kt:176)```

abelgardep avatar Apr 26 '21 09:04 abelgardep

@hannesa2 could you update this PR together with https://github.com/owncloud/android-library/pull/379 (or this branch, more recent: https://github.com/owncloud/android-library/tree/optionalLiveLogging)

The idea is checking this asap over our newest master in order to merge it before moving the library to a new module.

Thanks a lot in advance

jesmrec avatar May 30 '23 15:05 jesmrec