android icon indicating copy to clipboard operation
android copied to clipboard

[FEATURE REQUEST] Permission UI handling

Open jesmrec opened this issue 6 years ago • 4 comments

Is your feature request related to a problem? Please describe.

Permissions can not be increased when content is reshared. In case of a shared folder, all its contents must "inherit" the parent folder permissions.

Currently in Android app, by following these steps:

  • User1 shares a folder with User2, granting "share" and "create" permission and revoking "update" and "delete" permissions
  • User2 reshares with User3

the current behaviour is:

  • By default, shares are created with all permissions granted. To revoke permissions, share must be edited.
  • Share from User2 to User3 does not grant any permission by default (only read permission)
  • User2 edits his Share with User3. Everything is disabled. If User2 ticks "share" and "create" everything is OK (these are the permissions granted by User1). If User2 ticks "update" or "delete", a snackbar error message is displayed because the permissions are not granted by User1

Describe the solution you'd like

  • By default, shares are created with all permissions granted. To revoke permissions, share must be edited.

when a sharee is selected from the list of matches, list of permissions is displayed to be selected by the user to grant the sharee. Permissions by default are ticked/unticked depending values of capability "default_permissions"

  • User3 does not have any permission by default (only read permission)
  • User3 can tick all the permissions. If that permission is not granted, an alert is shown

Only displayed "create" and "share". "Update" and "delete" are hidden or greyed out.

TASKS

  • [ ] Research (if needed)
  • [ ] Create branch feature/feature_name
  • [ ] Development tasks
    • [ ] Implement whatever
    • [ ] ...
  • [ ] Code review and apply changes requested
  • [ ] Design test plan
  • [ ] QA
  • [ ] Merge branch feature/feature_name into master

PR

  • App
  • Library (if needed)

jesmrec avatar Jul 03 '19 16:07 jesmrec

@jesmrec Just for clarifying: The default permissions from the Capabilities are the issue here.

We should use the actual sharing permissions. These could be accessed in a PROPFIND on the file / Folder to reshare. I described it in the Enterprise Ticket

micbar avatar Jul 04 '19 07:07 micbar

i know that issue. The point is the flow in the android app should be changed to fit the flow you mentioned:

Open the share dialogue and only show the possible share permissions, higher permissions should be greyed out Create the share in the second step after setting all the attributes.

Actually: share dialog does not show any permission. It is not posible to set permissions in creation step, only by editing. This is the first step to do, before performing the second step (submission of the share).

If it is OK to set default permissions in the edit dialog, elaboration will be easier but the flow will not be the same as the mentioned one.

Is this clarifying? i can share more information if it is needed. Thanks for the feedback.

jesmrec avatar Jul 04 '19 07:07 jesmrec

@jesmrec Thanks, clarified now :-)

micbar avatar Jul 04 '19 07:07 micbar

Everything will change with oCIS…

michaelstingl avatar Feb 14 '23 13:02 michaelstingl