android Pause manual upload when wifi is off.

Actual behaviour

-Manual upload does not pause when wifi is disconnected or turned off. There is no option to change this behaviour. This is different to auto-upload, which does have wifi/charging option.

Expected behaviour

-We need an option to pause upload when wifi is off.

Environment data

Android version: 9

Device model: pixel 2 xl

Stock or customized system:stock

ownCloud app version2.9 beta 1

ownCloud server version:10.0.10.4

PR

App: https://github.com/owncloud/android/pull/2519

Oct 11 '18 02:10 daylightsports

Hi @daylightsports , thanks for reporting this, do you mean that the upload keeps running using your cellular data once there's no wifi connection?

Oct 18 '18 13:10 davigonz

Yes that's what happened. Tim

On 19 October 2018 00:06:42 David González Verdugo [email protected] wrote:

Do you mean that the upload keeps running using your cellular data once there's no wifi connection? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

Oct 21 '18 21:10 daylightsports

I will fix it.

Dec 09 '18 16:12 ghost

I will fix it.

Go for it @BigAdam2005 , if you need any help please ping me.

Dec 12 '18 09:12 davigonz

I have fixed it.

Dec 14 '18 14:12 ghost

@jesmrec Is this still required?

Apr 09 '19 17:04 shashvat-kedia

@sd1998 Yes, would be awesome!

There was an attempt not very long ago, but I don't know the status: https://github.com/owncloud/android/pull/2398 /cc @davigonz @jesmrec

Apr 09 '19 18:04 michaelstingl

We reviewed such PR but was not clear by the contributor, what the fix was doing.

Apr 10 '19 06:04 jesmrec

@jesmrec I would like to work on this.

Apr 10 '19 11:04 shashvat-kedia

go ahead, but please, do not forget other open PRs like https://github.com/owncloud/android/pull/2400

Apr 11 '19 06:04 jesmrec