OWLTools-Solr cleanup

[cmungall]

Not clear how much to invest if we want to instead switch to loading from blazegraph, or reuse monarch solr-loader.

• test suite
  • [ ] investigate best strategy for testing Flexdocs, cc @kltm
  • [ ] some tests such as AllOntologyLoaderIntegrationRunner fail and are skipped. Why?
  • [ ] do more thorough testing of logic
  • [ ] add tests for panther
• [ ] populate redundancy field
• [x] why is there two PANTHER classes? PANTHERGeneralSolrDocumentLoader and PANTHERSolrDocumentLoader
  • now understood. one populates documents following the general schema

[kltm]

Depending on what you are doing, I suspect the direct testing of flexdocs accomplishes little.

I unfortunately have little memory of AllOntologyLoaderIntegrationRunner--I suspect that this is not my code originally--but I can go through that at some point ans untangle what is going on.

which two panther classes are you referring to?

[cmungall]

only these ones are executed:

Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.648 sec - in owltools.solrj.BioentityClosureTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 34.772 sec - in owltools.solrj.GafSolrDocumentLoaderTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.05 sec - in owltools.solrj.TransitivityGraphTest

• AllOntologyLoaderIntegrationRunner.java, fails - does not find catalog
• FullTaxonIntegrationRunner.java fails - does not find a taxon file
• GafSolrDocumentLoaderIntegrationRunner.java - does not find catalog
• GoLoaderIntegrationRunner.java fails - no catalog
• OntologyAndGafLoaderIntegrationRunner.java fails - no catalog