owl icon indicating copy to clipboard operation
owl copied to clipboard

Unit Tests for CGraph

Open tachukao opened this issue 5 years ago • 2 comments

As discussed in #531, we should add an unit test module for CGraph. Although most of the operations are defined in Algodiff, we should have unit tests for the init, shape, and optimization functions. Any ideas on how to best test for these @pvdhove @ryanrhymes @mseri @jzstark ?

tachukao avatar Jul 24 '20 08:07 tachukao

Probably the tests can be divided into several groups.

  • Basic operations like adding, removing, modifying nodes.
  • Shape inference functions.
  • Structural optimisation functions.
  • Anything esle?

open to criticisms :)

ryanrhymes avatar Jul 24 '20 08:07 ryanrhymes

Agree. The optimiser and shape interence tests in TensorFlow might be of help, such as optimizer_cse_test.cc, constant_folding_test.cc, shape_inference_test.cc, etc.

jzstark avatar Jul 25 '20 11:07 jzstark