owid-grapher icon indicating copy to clipboard operation
owid-grapher copied to clipboard

Published 20 hours ago • verified publisher icon owid

feat(annotations): final changes

Open coder-whale opened this issue 2 years ago • 2 comments

  • Code cleanup
  • Algorithm tweak
  • Comments

coder-whale avatar Sep 11 '22 05:09 coder-whale

Thanks for the review Daniel! I have fixed the aforementioned issues. I also stumbled upon an issue with labeling for Chile, which I will be looking into tomorrow.

coder-whale avatar Sep 12 '22 23:09 coder-whale

Currently all possible fixes/improvements that I can think of are done (apart from admin changes which I will attempt to resolve on a separate PR). Do let me know if there is anything else that needs working on.

coder-whale avatar Sep 19 '22 00:09 coder-whale

Thank you @coder-whale, and sorry it took so long to merge this!

marcelgerber avatar Nov 09 '22 13:11 marcelgerber

No worries! Do let me know if I can help with any changes/improvements that need to be made for this feature.

coder-whale avatar Nov 09 '22 18:11 coder-whale

No worries! Do let me know if I can help with any changes/improvements that need to be made for this feature.

Sure! It'll take another while until we can see this feature land for real, but it will at some point :)

marcelgerber avatar Nov 10 '22 11:11 marcelgerber