owid-grapher icon indicating copy to clipboard operation
owid-grapher copied to clipboard

Repo is incompatible with Node 18

Open mathisonian opened this issue 2 years ago • 0 comments

Description

Currently the project can't be run using Node.js 18, only v16 or v17. We should fix this as node 16 will enter maintenance mode in October 2022 and its best to keep things relatively up-to-date and compatible to avoid potentially painful migrations later on.

Expected behaviour

Running make up.full with nodejs v18 is successful.

Steps to reproduce

Steps to reproduce the behavior:

  1. nvm use 18
  2. make up.full
  3. See error:
[email protected]: The engine "node" is incompatible with this module. Expected version "^12 || ^14 || ^16 || ^17". Got "18.2.0"

This is a sub-dependency of the @wordpress/scripts dependency which is currently at v19.2.3. The latest version of that package is v24.0.0. I believe upgrading to the latest version of that will fix the issue, but I'm not sure what potential changes we'll have to make to do that.

mathisonian avatar Sep 09 '22 21:09 mathisonian