owid-grapher icon indicating copy to clipboard operation
owid-grapher copied to clipboard

Docker `make up` not working

Open lucasrodes opened this issue 2 years ago • 1 comments

Description

I am trying to run the make up command but it is failing due to a problem with yarn.

Expected behaviour

A clear and concise description of what you expected to happen.

Steps to reproduce

✗ make up
==> Checking your local environment has the necessary commands...
==> Validating your .env file for make up
.env file valid for make up
==> Checking port
==> Building grapher
yarn install
yarn install v1.22.19
[1/5] 🔍  Validating package.json...
[2/5] 🔍  Resolving packages...
success Already up-to-date.
✨  Done in 0.31s.
yarn run tsc -b
yarn run v1.22.19
$ /Users/lucasrodes/repos/owid-grapher/node_modules/.bin/tsc -b
clientUtils/urls/Url.ts:9:9 - error TS2314: Generic type 'URLParse<Query>' requires 1 type argument(s).

9 ): Omit<urlParseLib, "query"> & { query: string } => {
          ~~~~~~~~~~~


Found 1 error.

error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
make: *** [up] Error 2

Environment

  • OS: Mac OS Monterrey (12.5)
  • node: v16.16.0
  • yarn: 1.22.19

I'm using an M1 Max machine.

lucasrodes avatar Aug 10 '22 12:08 lucasrodes

If I execute make up again I end up with a long list of errors. See some of them below:

(MORE ERROR MESSAGES ABOVE)

grapher/dataTable/DataTable.jsdom.test.tsx:20:23 - error TS2786: 'DataTable' cannot be used as a JSX component.
  Its instance type 'DataTable' is not a valid JSX element.

20         view = mount(<DataTable manager={grapher} />)
                         ~~~~~~~~~

grapher/dataTable/DataTable.jsdom.test.tsx:75:23 - error TS2786: 'DataTable' cannot be used as a JSX component.
  Its instance type 'DataTable' is not a valid JSX element.

75         view = mount(<DataTable manager={grapher} />)
                         ~~~~~~~~~

grapher/dataTable/DataTable.jsdom.test.tsx:111:25 - error TS2786: 'DataTable' cannot be used as a JSX component.
  Its instance type 'DataTable' is not a valid JSX element.

111     const view = mount(<DataTable manager={grapher} />)
                            ~~~~~~~~~

grapher/mapCharts/MapTooltip.jsdom.test.tsx:11:31 - error TS2786: 'Grapher' cannot be used as a JSX component.
  Its instance type 'Grapher' is not a valid JSX element.

11 const grapherWrapper = mount(<Grapher {...legacyMapGrapher} />)
                                 ~~~~~~~

grapher/stackedCharts/StackedDiscreteBarChart.stories.tsx:18:14 - error TS2786: 'StackedDiscreteBarChart' cannot be used as a JSX component.
  Its instance type 'StackedDiscreteBarChart' is not a valid JSX element.
    Types of property 'refs' are incompatible.
      Type '{ [key: string]: import("/Users/lucasrodes/repos/owid-grapher/node_modules/@types/react/index").ReactInstance; }' is not assignable to type '{ [key: string]: React.ReactInstance; }'.
        'string' index signatures are incompatible.
          Type 'import("/Users/lucasrodes/repos/owid-grapher/node_modules/@types/react/index").ReactInstance' is not assignable to type 'React.ReactInstance'.

18             <StackedDiscreteBarChart
                ~~~~~~~~~~~~~~~~~~~~~~~

grapher/stackedCharts/StackedDiscreteBarChart.stories.tsx:33:14 - error TS2786: 'StackedDiscreteBarChart' cannot be used as a JSX component.
  Its instance type 'StackedDiscreteBarChart' is not a valid JSX element.

33             <StackedDiscreteBarChart
                ~~~~~~~~~~~~~~~~~~~~~~~

grapher/text/MarkdownTextWrap.stories.tsx:100:26 - error TS2786: 'MarkdownTextWrap' cannot be used as a JSX component.
  Its instance type 'MarkdownTextWrap' is not a valid JSX element.

100                         <MarkdownTextWrap
                             ~~~~~~~~~~~~~~~~

grapher/text/MarkdownTextWrap.stories.tsx:123:52 - error TS2786: 'MarkdownViewer' cannot be used as a JSX component.
  Its instance type 'MarkdownViewer' is not a valid JSX element.
    Types of property 'refs' are incompatible.
      Type '{ [key: string]: import("/Users/lucasrodes/repos/owid-grapher/node_modules/@types/react/index").ReactInstance; }' is not assignable to type '{ [key: string]: React.ReactInstance; }'.
        'string' index signatures are incompatible.
          Type 'import("/Users/lucasrodes/repos/owid-grapher/node_modules/@types/react/index").ReactInstance' is not assignable to type 'React.ReactInstance'.

123 export const MarkdownPreview = (): JSX.Element => <MarkdownViewer />
                                                       ~~~~~~~~~~~~~~


Found 242 errors.

error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
make: *** [up] Error 2

lucasrodes avatar Aug 10 '22 12:08 lucasrodes

@lucasrodes Sorry I only just saw this, did you get it working in the end?

larsyencken avatar Aug 30 '22 11:08 larsyencken

I finally worked, although I am unsure what was that was failing. My bad, should have posted it!

Closing it

lucasrodes avatar Aug 30 '22 14:08 lucasrodes