owid-grapher icon indicating copy to clipboard operation
owid-grapher copied to clipboard

Published 20 hours ago • verified publisher icon owid

Scatterplots mark non-countries as "No data" in the legend

Open larsyencken opened this issue 3 years ago • 3 comments

Description

If a scatterplot contains regions, they are listed in the legend as "No data".

Screen Shot 2022-02-16 at 11 42 16

Expected behaviour

They should probably be listed as "Other" in the data.

Proposed fix

  • [ ] Rename "No data" label to "Other" for all charts
  • [ ] Add config options for the "no data" situation (label, colour)
    • [ ] Add to the grapher schema
    • [ ] Add to the admin
    • [ ] Do a schema migration of all past colour palettes

larsyencken avatar Feb 16 '22 10:02 larsyencken

I think the ideal fix for the Continents variable specifically is to define color scales on the variable level. Then, for the Continents variable, we can set the "No data" label to something better.

But in general, the "No data" label could be improved. On maps it makes sense because only 1 variable is plotted, so if there is no color there really is no data. But for scatter plots that's not the case.

danielgavrilov avatar Feb 16 '22 11:02 danielgavrilov

Ah wait, I just saw that daniel was unassigned from this issue. Why is that? Is the fix in #1306 not worth pursuing?

marcelgerber avatar Apr 01 '22 08:04 marcelgerber

Ah wait, I just saw that daniel was unassigned from this issue. Why is that? Is the fix in #1306 not worth pursuing?

It was actually that it spilled over quite far into this cycle, stopping Daniel from starting the planned work for this cycle (tolerance refactoring). We needed to start tolerance early to have a hope of finishing it by the end of the cycle.

larsyencken avatar Apr 11 '22 15:04 larsyencken

This issue would be good to fix, when we have the time.

Relatedly it'd be good to not assign the population size to the size of the bubble for world regions – and especially for the entity 'World'. Because that means that the 'World'-bubble is massive and all others small.

maxroser avatar Dec 07 '22 17:12 maxroser

This came up again, brought to our attention by Natasha on Slack

Link: https://ourworldindata.org/grapher/mean-height-males-vs-females?country=East+Asia+and+Pacific~Europe+and+Central+Asia~Latin+America+and+Caribbean~Middle+East+and+North+Africa~North+America~South+Asia~Sub-Saharan+Africa~OWID_WRL

mean-height-males-vs-females

sophiamersmann avatar Mar 15 '23 13:03 sophiamersmann

@samizdatco I suggest shipping the simplest possible fix first, that of hiding "No data" in the legend, and deferring any more sophisticated aggregate handling until we have a more compelling need.

larsyencken avatar Mar 27 '23 21:03 larsyencken