etl icon indicating copy to clipboard operation
etl copied to clipboard

chart-sync: use more informative user name in approval tool

Open lucasrodes opened this issue 11 months ago • 3 comments

Problem

Currently, when a user uses the chart-sync, all charts modified in the source server are put in the queue of the chart approval tool under the user name "ETL":

image

This could be more informative. Instead, we could label it according to the branch that created the staging server, e.g. "fix/population".

Technical notes

This is a bit tricky, as the SuggestedChartRevisions object is created with the user ID (and not user name). Key code to change:

lucasrodes avatar Mar 05 '24 23:03 lucasrodes

Good idea, though might not be trivial if we don't know how to effectively do development chart revision tool. (Could be also parked until we decide to refactor it in streamlit)

Marigold avatar Mar 06 '24 09:03 Marigold

Related to #2465

larsyencken avatar Mar 28 '24 10:03 larsyencken

(quick follow-up on this issue)

Recently I thought of a quick win in this domain, and it occurred to me that we could add some note in the "Reason for suggested revision" field, which is shown at the bottom of the suggestion (see screenshot) and comes from the field suggestedReason in table suggested_chart_revisions.

image

We might move the chart approval tool to Streamlit at some point, so this solution doesn't take much time.

This quick solution wouldn’t provide filtering, but it could be a hacky way to see where that revision comes from without touching any typescript.

lucasrodes avatar Mar 28 '24 10:03 lucasrodes

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar May 27 '24 14:05 stale[bot]

This is no longer on the roadmap, given that we will be switching to a new workflow: https://github.com/owid/etl/issues/2580

lucasrodes avatar May 28 '24 12:05 lucasrodes