gi-gtk-declarative icon indicating copy to clipboard operation
gi-gtk-declarative copied to clipboard

Published 20 hours ago • verified publisher icon owickstrom

CustomWidget is always modified or replaced?

Open wavewave opened this issue 3 years ago • 2 comments

From this code bit https://github.com/owickstrom/gi-gtk-declarative/blob/b876aab4ee8b1e1e799c5346cade687429cd5ee3/gi-gtk-declarative/src/GI/Gtk/Declarative/CustomWidget.hs#L80 CustomKeep case is never mapped to Keep in Patch, therefore it induces lots of unnecessary UI updates. I noticed this from my work. Is there any reason that it was implemented in that way? Thanks.

wavewave avatar Aug 26 '21 14:08 wavewave

Thanks for the report! It does look like an oversight, indeed. Would you be willing to submit a PR and add the missing handling of Keep?

owickstrom avatar Aug 28 '21 20:08 owickstrom

Yes, I will. I haven't tried to patch this yet, but definitely I can try in my current work context. Thanks.

wavewave avatar Sep 03 '21 02:09 wavewave