Owen Waller

Results 125 comments of Owen Waller

See PR #350 which disables the entire `legacy-wasm-test-suite`. As a result this needs to be fixed urgently. At that point the entire `legacy-test-suite` can be removed.

See PR #350 which disables the entire `legacy-wasm-test-suite`. As a result this needs to be fixed urgently. At that point the entire `legacy-test-suite` can be removed.

@deadprogram Ah ha, that is indeed the problem. If I swap the `wasm_exec.js` for the one currently on the master branch: https://github.com/tinygo-org/tinygo/blob/release/targets/wasm_exec.js Then all is good using with `tinygo v...

Updated to add: A similar situation exists with the standard Go compiler i.e. the version of `wasm_exec.js` must match the version of the compiler. But, given a `wasm_exec.js` e.g. one...

@gedw99 [`vugu`](https://github.com/vugu/vugu) isn't building being build with `tinygo`. Nor are we building the newer `wasm-test-suite` with `tinygo`. We do build the `legacy-wasm-tst-suite` with `tinygo`, using the latest `tinygo` version. But...

@gedw99 @deadprogram Ah, but this actually shows the problem I am trying to get the `tinygo` team to fix. The problem is, in the code that was [referenced](https://github.com/syumai/workers/blob/main/handler_js.go) it uses...

@bradleypeabody I haven't though of adding a switch to `vugugen`. It's possible but its more code. The PR as it stands isn't as big a change as you might expect....

@bradleypeabody I think that's incorrect. If your build target is GOOS=Darwin GOARCH=arm64 for example then your server side render code will still call `vugu/js` and it'll do the right thing....

@bradleypeabody I've just merged in PR #356, #357. #356. #359 into this the PR for this proposal (#354). Everything still passes as evidenced by the last GitHub Action run on...

Please see the extensive comment in commit #[deaed0a](https://github.com/vugu/vugu/pull/354/commits/deaed0afc0889c674592aae84c1e1c93f3ca6b3e) I've updated the PR so that the `gen` package tests now pass using the correct '*_gen_notjs_notwasm.go" filenames. This removes the limitations above...