WenTao Ou

Results 226 comments of WenTao Ou

We have a internal prometheus file exporter(which can be push to opentelemetry-cpp-contrib later after we test foe some time). The options are like this: ```cpp /** * Struct to hold...

> It is good to have a look into the configuration option for the OTLP Collector file exporter too - https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/v0.92.0/exporter/fileexporter/README.md. This file exporter uses time to rotate files, and...

> See related: > > * [Is OTLP file exporter required for SDKs? opentelemetry-specification#3817](https://github.com/open-telemetry/opentelemetry-specification/issues/3817) Thanks, I will follow this issue.

> @owent @lalitb @marcalff I'm planning to deploy opentelemetry as the primary logging system for my organization's c++ projects, and we have a requirement for exporting logs to disk before...

I have implemented a prometheus file exporter before, which also support file rotate and has a alias name which always link to the latest file.Just like the comment in `struct...

> I'm sorry about that @owent. I wasn't able to get permission from higher ups in time to submit a PR earlier. I have just create a draft PR yestoday...

Good point. I think we can set the default value of `OPENTELEMETRY_BUILD_DLL` to `ON` when `BUILD_SHARED_LIBS` is `ON`. But just wondering do we need change `add_library` calls to `add_library(mytarget ${OPENTELEMETRY_LIBRARY_TYPE}...

> @marcalff @owent Was the reason(s) for why `${OPENTELEMETRY_LIBRARY_TYPE}` is needed clearly explained? > > If you agree, I'll sketch it up in a PR. Good point. I think it's...

Just wondering, is it possiable if include #2407 into 1.14.0?

> Is it possible to add a test case to reproduce the issue and verify the fix? Good point. But this problem is hard to reproduce. I have no idea...