vscode-swift icon indicating copy to clipboard operation
vscode-swift copied to clipboard

Please avoid node dependency to "natives" module

Open bpasero opened this issue 7 years ago • 1 comments

Hi,

I am a developer on VSCode and wanted to reach out to inform you that this extension is either using or having a dependency to a node module "natives" that will soon no longer be supported in VSCode once we updated to node.js 8.x (as part of our Electron 2.0 update which is planned for the near term).

The full graph is:

└─┬ [email protected]
  └─┬ [email protected]
    └─┬ [email protected]
      └── [email protected] 

It would be great if this dependency could be avoided by either not depending on it anymore or updating the dependencies to newer versions so that this module is no longer pulled in.

As soon as any code in your extension (including node_modules) calls require("natives") we will throw an exception to prevent this module from getting loaded.

If this is just a devDependency and the module is never loaded in production, then you can ignore this issue and just close it!

More details in https://github.com/Microsoft/vscode/issues/47569

Thanks! Ben VSCode Team

bpasero avatar Apr 10 '18 15:04 bpasero

A good alternative node module to unzip seems to be unzip-stream, a fork of the unzip library with similar API.

bpasero avatar Apr 10 '18 16:04 bpasero