amass icon indicating copy to clipboard operation
amass copied to clipboard

fix: panic on json encoding

Open gfrancqu opened this issue 2 years ago • 3 comments

using json output sometimes trigger a panic, issue seems to happen because a goroutine modify the output object while it is being encoded, adding a mutex solve the issue

gfrancqu avatar Jun 17 '22 18:06 gfrancqu

fix #800

gfrancqu avatar Jun 17 '22 18:06 gfrancqu

Codecov Report

Merging #845 (543bdde) into develop (5f07a52) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #845   +/-   ##
========================================
  Coverage    39.46%   39.46%           
========================================
  Files           42       42           
  Lines         5307     5307           
========================================
  Hits          2094     2094           
  Misses        3115     3115           
  Partials        98       98           
Impacted Files Coverage Δ
github.com/OWASP/Amass/requests/request.go 62.75% <0.00%> (ø)

codecov[bot] avatar Jun 27 '22 14:06 codecov[bot]

The changes have caused the lints/tests to fail and will not be an acceptable solution

caffix avatar Jun 27 '22 14:06 caffix