amass icon indicating copy to clipboard operation
amass copied to clipboard

Published 20 hours ago • verified publisher icon owasp-amass

Refactor config/resolvers.go, update resolvers_test.go

Open VltraHeaven opened this issue 2 years ago • 2 comments

Hello @caffix

  • Unit and benchmark tests added to config/resolvers_test.go to improve code coverage for methods in config/resolvers.go
  • Moved functionality of AddResolvers and AddResolver methods into SetResolvers
  • Moved functionality of AddTrustedResolvers and AddTrustedResolver methods into SetTrustedResolvers

VltraHeaven avatar Apr 27 '22 20:04 VltraHeaven

Any recommendations for changes to this PR?

VltraHeaven avatar May 04 '22 18:05 VltraHeaven

Codecov Report

Merging #814 (1abe612) into develop (e0e5c5c) will increase coverage by 0.66%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #814      +/-   ##
===========================================
+ Coverage    39.46%   40.12%   +0.66%     
===========================================
  Files           42       42              
  Lines         5307     5295      -12     
===========================================
+ Hits          2094     2124      +30     
+ Misses        3115     3070      -45     
- Partials        98      101       +3
Impacted Files Coverage Δ
github.com/OWASP/Amass/config/scope.go 89.70% <0.00%> (-0.51%) :arrow_down:
github.com/OWASP/Amass/config/resolvers.go 76.82% <0.00%> (+49.66%) :arrow_up:

codecov[bot] avatar Jun 24 '22 19:06 codecov[bot]