octotree icon indicating copy to clipboard operation
octotree copied to clipboard

Feature idea: In PR review mode have a way to mark a file as reviewed

Open orium opened this issue 6 years ago • 4 comments

The ability to mark files as already reviewed can be very useful, since reviewing is often (almost always?) non-linear. Something that has some sort of nice clear visual indication, like changing the background color of the file.

orium avatar Jan 17 '19 13:01 orium

This is a good idea. How do you propose we mark the file as reviewed?

buunguyen avatar Mar 20 '19 23:03 buunguyen

For instance having a checkbox right next to each file/directory? With a nice keybind as well :slightly_smiling_face:

For instance something like this:

Maybe even set the background color of the files checked to green.

orium avatar Mar 21 '19 11:03 orium

Thanks. This would be the most straightforward way to build this. Honestly I'm not a fan of a bunch of checkboxes :). I'll think more about this.

buunguyen avatar Mar 21 '19 17:03 buunguyen

It is a bit ugly visually , yes. Maybe there can be some buttons that appear only on-hover on the right of the file. Visual indication that something has been reviewed would be just a green background color on the file, for instance.

orium avatar Mar 21 '19 18:03 orium