sokol-multithread icon indicating copy to clipboard operation
sokol-multithread copied to clipboard

Returning error if uniform size is too big

Open eduardodoria opened this issue 1 year ago • 2 comments

In this part is interesting to return an error or print if size is too big:

// data size too big?
if ((size_t)data.size > sizeof(SokolRenderCommand::apply_uniforms.buf))
{
return;
}

Can be hard to debug!

eduardodoria avatar Mar 05 '23 18:03 eduardodoria

Yes, that would make sense.

Possible even an assert?

oviano avatar Mar 05 '23 18:03 oviano

Possible even an assert?

Yes, Sokol style assert should be good.

eduardodoria avatar Mar 05 '23 18:03 eduardodoria