venom icon indicating copy to clipboard operation
venom copied to clipboard

Lazy expansion of json payloads that we get from user executors

Open fokion opened this issue 2 years ago • 2 comments

This is done in order to avoid expanding and storing big payloads that we dont need and we dont use for assertions. The flag is called VENOM_NO_JSON_EXPANSION.

fokion avatar Oct 21 '23 23:10 fokion

https://github.com/ovh/venom/pull/708

fokion avatar Oct 23 '23 08:10 fokion

The idea is that you can have a big JSON payload , by default we will try to unmarshal it and we may not use the new keys in any assertion. That will cause issues with performance as the constant unmarshalling , copying of values with increase memory and cpu usage. The point here is to unmarshal this payload lazily and for now have that feature tested under a flag so that we dont affect everyone.

fokion avatar Oct 23 '23 17:10 fokion

Closing this pull-request for now: we don't want to add a global flag, unless it's a new feature that we want to test and include in the next major release.

yesnault avatar Aug 13 '24 16:08 yesnault