venom icon indicating copy to clipboard operation
venom copied to clipboard

Consider including Venom in asdf plugins

Open x80486 opened this issue 4 years ago • 1 comments

I filed an issue in the asdf-plugins repository.

asdf plugins are quite straightforward to develop, but it's always better if project maintainers are involved.

x80486 avatar Oct 09 '21 02:10 x80486

@x80486 creating plugins are pretty straight forward indeed; I've done a few now. You should check out the plugin guide which details how the template gives you some guardrails and the PR process will require the maintainers to review any plugin that is added. I haven't used this tool before, but looking at venom's releases, it should fit the asdf use case well. You could use this repo I maintain the asdf plugin for, as an example of a similar cross-compiled binary release plugin. Another plugin i've worked on of a tool that might be more familiar is the command line yaml parser yq The neat thing about the install script, is it will use other command line tools like uname to detect the system architecture, and install the correct binary for each system it runs on https://github.com/sudermanjr/asdf-yq/blob/master/bin/install#L23-L34

getArch() {
  ARCH=$(uname -m)
  case $ARCH in
    armv*) ARCH="arm";;
    aarch64) ARCH="arm64";;
    x86) ARCH="386";;
    x86_64) ARCH="amd64";;
    i686) ARCH="386";;
    i386) ARCH="386";;
  esac
  echo "$ARCH"
}

Feel free to ask questions if you run into issues.

mathew-fleisch avatar Oct 26 '21 14:10 mathew-fleisch