manager icon indicating copy to clipboard operation
manager copied to clipboard

Published 20 hours ago • verified publisher icon ovh

feat(pci.project): instane config page update

Open vks-ovh opened this issue 2 years ago • 1 comments

Question Answer
Branch? feat/l3-services
Bug fix? no
New feature? yes
Breaking change? no
Tickets Fix #MANAGER-9389
License BSD 3-Clause

  • [x] Try to keep pull requests small so they can be easily reviewed.
  • [x] Commits are signed-off
  • [x] Only FR translations have been updated
  • [x] Branch is up-to-date with target branch
  • [x] Lint has passed locally
  • [x] Standalone app was ran and tested locally
  • [x] Ticket reference is mentioned in linked commits (internal only)
  • ~~[ ] Breaking change is mentioned in relevant commits~~

Description

Modification of pci instance config page.

Related

vks-ovh avatar Aug 12 '22 12:08 vks-ovh

@vks-ovh not possible to handle the sonar security hotspot and code smell ?

marie-j avatar Sep 09 '22 12:09 marie-j

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 3 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
3.5% 3.5% Duplication

sonarqubecloud[bot] avatar Sep 12 '22 05:09 sonarqubecloud[bot]

@vks-ovh not possible to handle the sonar security hotspot and code smell ?

Hi @marie-j, I fixed the sonar code smell issue but for security hotspot, I am not sure how to take care of that. Security hotspot issue is due to some hardcoded constant which I maintain. I don't have any other option to maintain it. Can you please suggests something, if we can make it false positive or any way to ignore this constant file hardcoded ip?

vks-ovh avatar Sep 12 '22 06:09 vks-ovh