manager
manager copied to clipboard
fix(sso-auth): add target top for signup new redirection
| Question | Answer |
|---|---|
| Branch? | master |
| Bug fix? | yes |
| New feature? | no |
| Breaking change? | no |
| Tickets | DTRSD-95297 |
| License | BSD 3-Clause |
- [x] Try to keep pull requests small so they can be easily reviewed.
- [x] Commits are signed-off
- [ ] ~~Only FR translations have been updated~~
- [x] Branch is up-to-date with target branch
- [x] Lint has passed locally
- [x] Standalone app was ran and tested locally
- [x] Ticket reference is mentioned in linked commits (internal only)
- [ ] ~~Breaking change is mentioned in relevant commits~~
Description
I added target top for signup new redirection if nic have partiel registration. I also fixed a console message related to the variable newZipModel that not tested.
Related
Kudos, SonarCloud Quality Gate passed! 
0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells
No Coverage information
0.0% Duplication
What is the purpose of the target top here? If i'm not mistaken, signup is not in the container or in an iframe, why do we need to target top ?
What is the purpose of the target top here? If i'm not mistaken, signup is not in the container or in an iframe, why do we need to target top ?
If we don't put a "top", we stay on the manager's loader and we already have the navbar while the account is not yet finalized.