manager feat(vpn): set private network on creation by default

feat(vpn): set private network on creation by default

Open blemoineovh opened this issue 1 year ago • 5 comments

Question Answer

Branch? master

Bug fix? no

New feature? no

Breaking change? no

Tickets Fix #10454

License BSD 3-Clause

Question	Answer
Branch?	`master`
Bug fix?	no
New feature?	no
Breaking change?	no
Tickets	Fix #10454
License	BSD 3-Clause

[x] Try to keep pull requests small so they can be easily reviewed.
[x] Commits are signed-off
[ ] Only FR translations have been updated
[x] Branch is up-to-date with target branch
[x] Lint has passed locally
[x] Standalone app was ran and tested locally
[ ] Ticket reference is mentioned in linked commits (internal only)
[ ] Breaking change is mentioned in relevant commits

Description

When we create a network service, set it as private by default instead of public

Dec 21 '23 11:12 blemoineovh

@blemoineovh your commit message is wrong replace ticket #MANAGER-12914 by ref: MANAGER-12914

Jan 12 '24 15:01 darsene

[this.selectedMode] @darsene

yup, it would be cleaner to work with constants that state private_mode or public_mode instead of an index in an array where did i forgot to change something in add.html ?

Jan 16 '24 08:01 blemoineovh

@blemoineovh your commit message is wrong replace ticket #MANAGER-12914 by ref: MANAGER-12914

ok updated commit message

Jan 16 '24 08:01 blemoineovh

Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Jan 18 '24 11:01 sonarqubecloud[bot]

Maybe you can also replace 'public_mode' and 'private_mode' in https://github.com/ovh/manager/blob/9ff3bfe6c0a6e4858605f17dfc459179cdd081a5/packages/manager/modules/pci/src/projects/project/instances/add/add.html#L496 with the constant you just created