manager icon indicating copy to clipboard operation
manager copied to clipboard

split vrack allowed services calls

Open blemoineovh opened this issue 2 years ago • 3 comments

Question Answer
Branch? master
Bug fix? yes
New feature? yes
Breaking change? no
Tickets Fix #MANAGER-12446
License BSD 3-Clause

  • [x] Try to keep pull requests small so they can be easily reviewed.
  • [x] Commits are signed-off
  • [x] Only FR translations have been updated
  • [x] Branch is up-to-date with target branch
  • [x] Lint has passed locally
  • [x] Standalone app was ran and tested locally
  • [x] Ticket reference is mentioned in linked commits (internal only)
  • [ ] Breaking change is mentioned in relevant commits

Description

After changing the endpoint vrack-allowed-service to be able to recieve calls for only one family, this PR adds the ability to get rid of timeout when requesting the services of all the families available to add to a vrack. This is done by calling each family separately in the manager and show a counter of the calls. The getting of the service id and a display name is processed just like before with a more fail safe approach.

Related

See the changes in the 2api endpoint vrack-allowed-services, it is still able to retrieve the call to all available services just like before, without any family filter.

blemoineovh avatar Dec 14 '23 09:12 blemoineovh

fixes #MANAGER-12446

blemoineovh avatar Dec 20 '23 09:12 blemoineovh

The check git (lint code / lint commit) are failed. Can you check ? The ref of ticket are missing for example in commit message.

ghyenne avatar Feb 12 '24 09:02 ghyenne

Quality Gate Passed Quality Gate passed

Issues
2 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Feb 27 '24 17:02 sonarqubecloud[bot]

This Pull Request is stale due to inactivity since 30 days. If no activity happens for 15 more days from now, it will be closed.

github-actions[bot] avatar Apr 01 '24 00:04 github-actions[bot]

This Pull Request is now closed due to inactivity.

github-actions[bot] avatar Apr 24 '24 00:04 github-actions[bot]