yupi icon indicating copy to clipboard operation
yupi copied to clipboard

Handlers/Composers structure Templating (ProtoBuf)

Open BurakDev opened this issue 8 years ago • 9 comments

This issue is open to debate and talk about a templating system for packets structures.

This feature will allow emulator to support easily multiple releases (and structures changes).

List of ideas :

  • [ ] Using homemade templating (RELEASE63-XXXXXXXX-XXXX/Handlers/*Event.model)
  • [ ] Using ProtoBuf (support Habbo binary protocol natively)

BurakDev avatar Sep 19 '16 16:09 BurakDev

Will be only for Incoming or Outgoing Packets? If for those two, need be *Composer, *Event

ovflowd avatar Sep 19 '16 16:09 ovflowd

Incoming and Outgoing, Incoming to automaticly parsing and checking all packet in one step and Outgoing to automaticly build packet with all needed data.

BurakDev avatar Sep 19 '16 16:09 BurakDev

Write in the Issue Description information about Protobuf, please.

ovflowd avatar Sep 19 '16 16:09 ovflowd

That's important if we move to new crypto @BurakDev @TheDoct0r11 @ZakAmirz @Nenji

ovflowd avatar Sep 20 '16 14:09 ovflowd

ProtoBuf is a cool tool, but sadly useless for our requirements: https://developers.google.com/protocol-buffers/docs/encoding

TheDoct0r11 avatar Sep 20 '16 21:09 TheDoct0r11

O don't think is useless. @BurakDev what you think?

ovflowd avatar Sep 20 '16 21:09 ovflowd

@sant0ro It just won't work. Look at the link I've posted. The encoding isn't compatible with the client.

TheDoct0r11 avatar Sep 20 '16 21:09 TheDoct0r11

We just can't encode in our way?

ovflowd avatar Sep 20 '16 21:09 ovflowd

From what I've read I don't think so. The library is designed to detect different message versions, but it does this per message, not per client.

TheDoct0r11 avatar Sep 20 '16 22:09 TheDoct0r11