The parser tests are broken

[peterwvj]

Not all of the parser tests get executed and the test suites do not detect when new parser tests are being added. It seems like this problem has been present for quite some time. The problem is easy to demonstrate: runmvn test in <ovt>/core/parser, and then the Maven output shows that no tests are found for many of the test suites.

[peterwvj]

I looked into this. The parser tests are awfully broken and rely on some old testing mechanism. Instead of trying to patch it I think the tests need to be re-written from scratch. Does the new test framework support parser testing, @ldcouto or does it always assume a parse correct AST?

[ldcouto]

It supports parser testing through the fine gained test class. I am fully in favour of migrating the tests. Happy to support such effort.

--luis On 14 Jul 2016 11:00, "Peter W. V. Tran-Jørgensen" [email protected] wrote:

I looked into this. The parser tests are awfully broken and rely on some old testing mechanism. Instead of trying to patch it I think the tests need to be re-written from scratch. Does the new test framework support parser testing, @ldcouto https://github.com/ldcouto or does it always assume a parse correct AST?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/overturetool/overture/issues/580#issuecomment-232621572, or mute the thread https://github.com/notifications/unsubscribe/AAjkkRwvt9U8qSe3wqtjYM8xycgIN6TLks5qVgi8gaJpZM4JJjzK .

[peterwvj]

Thanks Luis. I'm facing a problem though. The project that contains the ParamFineGrainTest depends on the parser so I can not use the ParamFineGrainTest in the parser without introducing a dependency cycle. Now Maven is complaining. Can we do something about this?

[peterwvj]

I mean, obviously we would need to move a part of the framework into another project, but I'm not sure what's the best way to do this.

[ldcouto]

Oh yeah, you're right. You need to split the Fine Grain class (and it's dependencies) into a separate maven project. I can take care of it. Can I branch off your work?

--luis

On 14 July 2016 at 21:06, Peter W. V. Tran-Jørgensen < [email protected]> wrote:

I mean, obviously we would need to move a part of the framework into another project, but I'm not sure what's the best way to do this.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/overturetool/overture/issues/580#issuecomment-232776818, or mute the thread https://github.com/notifications/unsubscribe/AAjkkWzvsFdioOckN_aplhu3EeT2RbRJks5qVpbRgaJpZM4JJjzK .

[peterwvj]

Thanks. It's best if you branch off pvj/main. Please note that I upgraded Overture to build against Eclipse Neon as described in #583. This might give you some problems with your current development environment, I'm not sure. If you don't want to struggle with Neon related issues then it's better to branch off test or ncb/development.

[ldcouto]

It's fine. I won't need Neon to work on the test framework. I'll try pvj/main.

On 17 July 2016 at 17:40, Peter W. V. Tran-Jørgensen < [email protected]> wrote:

Thanks. It's best if you branch off pvj/main. Please note that I upgraded Overture to build against Eclipse Neon ad described in #583 https://github.com/overturetool/overture/issues/583. This might give you some problems with your current development environment, I'm not sure. If you don't want to struggle with Neon related issues then it's better to branch off test or ncb/development.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/overturetool/overture/issues/580#issuecomment-233190887, or mute the thread https://github.com/notifications/unsubscribe-auth/AAjkkeExE9tOWj9UeTwwqF4a4XwUprVPks5qWlr7gaJpZM4JJjzK .