overte icon indicating copy to clipboard operation
overte copied to clipboard

Potentially duplicate FileDiolog.qml

Open Armored-Dragon opened this issue 1 year ago • 1 comments

This issue is opened at the request of some users in the hub for discussion. There are some files which look to be largely, but not entirely, duplicate qml files.

I've been doing testing on trying to see if I could replace the internal file picker and use the system's file picker. It seems like these files are used somewhere.

Maybe these could be condensed?

https://github.com/overte-org/overte/blob/9b89b3ffd9fe8bd9bd417f5a950b094aa807e577/interface/resources/qml/dialogs/FileDialog.qml

https://github.com/overte-org/overte/blob/9b89b3ffd9fe8bd9bd417f5a950b094aa807e577/interface/resources/qml/dialogs/TabletFileDialog.qml

https://github.com/overte-org/overte/blob/9b89b3ffd9fe8bd9bd417f5a950b094aa807e577/interface/resources/qml/hifi/tablet/tabletWindows/TabletFileDialog.qml

Armored-Dragon avatar Mar 02 '24 23:03 Armored-Dragon

This will likely be addressed with PR #886

Armored-Dragon avatar Mar 27 '24 23:03 Armored-Dragon