overte icon indicating copy to clipboard operation
overte copied to clipboard

Update ArmoredChat to coding standards

Open Armored-Dragon opened this issue 6 months ago • 3 comments

~~Do not merge unless https://github.com/overte-org/overte/pull/1677 is merged.~~

This pull request makes the chat application in compliance with the coding standard.

Changed:

Armored-Dragon avatar Jul 07 '25 08:07 Armored-Dragon

A thing I immediately noticed during testing: This breaks the chat bubbles. The typing indicator still works, but no chat bubble appears over a client running this PR. Even if you have two clients running this PR they cannot see each other's chat bubbles.

This PR also seems to be incompatible with previous versions of the chat. If I send a message from the PR and have a client on master, then the master client doesn't receive the message.

JulianGro avatar Aug 13 '25 08:08 JulianGro

A thing I immediately noticed during testing: This breaks the chat bubbles.

I neglected to check chatBubbles.js for incompatibilities. This should have been fixed with https://github.com/overte-org/overte/pull/1679/commits/1c5d2a1e8f8801ff3540c318e1f5f2c6ae1cd5ec.

This PR also seems to be incompatible with previous versions of the chat.

Simple oversight, should be fixed with the same commit. https://github.com/overte-org/overte/pull/1679/commits/1c5d2a1e8f8801ff3540c318e1f5f2c6ae1cd5ec

Armored-Dragon avatar Aug 13 '25 09:08 Armored-Dragon

Somehow legacy compatibility seems to still be broken. Auswahl_062

JulianGro avatar Aug 28 '25 10:08 JulianGro