overte-org
Warnings as errors is causing trouble when building on newer compiler versions
Could we disable warnings as errors by default, and enable them in CI builds? It's a very useful feature for CI, but right now if users try building Overte from source on modern distros, it will error out. Currently it fails on Debian Testing for example, and such failures are very probable to happen when using newer compiler.
We had a conversation about this on Discord. For now I'll keep this issue open to remember to document OVERTE_WARNINGS_AS_ERRORS cmake variable in BUILD.md, since build will fail on most compiler updates on Linux and it may be confusing in current state.
We could enable warnings as errors on certain compilers, instead of enabling it everywhere. Currently, the “expected” compiler on Linux is GCC 11 (which is the one used on Ubuntu 22.04). Even on GCC 12, we throw a lot of warnings currently. So on Linux, we could just have warnings as errors enabled on GCC 11, and disable it on newer (and older) versions.
Windows toolchain is more stable, so maybe we can just always have it enabled there.
