overte icon indicating copy to clipboard operation
overte copied to clipboard

fix noNetwork and add documentation for automated entity property files

Open HifiExperiments opened this issue 1 year ago • 2 comments

closes #1223

also fixes the problem with noNetwork that was the cause of #1222

HifiExperiments avatar Nov 17 '24 22:11 HifiExperiments

Can we merge this PR?

ksuprynowicz avatar Feb 14 '25 09:02 ksuprynowicz

yeah it’s all ready for review!

HifiExperiments avatar Feb 14 '25 14:02 HifiExperiments

this PR could use a real quick test so we can finally merge it if anyone has a sec. really just need to confirm that entityHostType still appears in the results of Entities.getEntityProperity(<some entity ID>)

HifiExperiments avatar Jun 10 '25 08:06 HifiExperiments

(After rebasing on master because I didn't want to have to deal with vcpkg again,) entityHostType shows up fine in Entities.getEntityProperties when selected specifically but isn't in the "everything" null case, the same behavior as 2025.05.01

Network play looks fine too at a glance, nothing is severely broken and the hub loads fine

ada-tv avatar Jun 10 '25 23:06 ada-tv

cool, if the behavior is the same sounds like it’s good to merge!

thank you for testing ❤️

HifiExperiments avatar Jun 10 '25 23:06 HifiExperiments