overte icon indicating copy to clipboard operation
overte copied to clipboard

Fix Create App not honoring menu bar actions

Open Armored-Dragon opened this issue 1 year ago • 2 comments

This implements a workaround for the Create app so that it responds to presses on the menu bar. Screenshot_20240827_145213

Fixes https://github.com/overte-org/overte/issues/588

Armored-Dragon avatar Aug 27 '24 21:08 Armored-Dragon

What exactly does this do? It sounds like this fixes the buttons on the menu bar, but the code seems to match pressing specific keys instead. Does this fix the keyboard shortcuts?

JulianGro avatar Sep 02 '24 10:09 JulianGro

What exactly does this do? It sounds like this fixes the buttons on the menu bar, but the code seems to match pressing specific keys instead. Does this fix the keyboard shortcuts?

The effective fix is to listen for the key combinations emitted by the menu bar buttons and not the menu bar buttons themselves. This explains a tiny bit more. I have severed a lot of internal key combinations as I think they were made with the assumption that the windows "Create Tools" and "Entity List" could not emit key combinations to the entire interface? It even looks as if some key combinations are defined twice, for which their maybe a good reason for, but other than my guess above, I can't find anywhere the application fails off of this PR.

I have only tested this on Arch Linux desktop mode. At some point I or someone else will need to test in VR mode to make sure everything works. Mac support was also impacted as I did remove an instance of their key press and replaced it with a direct call to the function.

Armored-Dragon avatar Sep 02 '24 17:09 Armored-Dragon

I just tested it, works perfectly :)

ksuprynowicz avatar Oct 05 '24 20:10 ksuprynowicz