overte icon indicating copy to clipboard operation
overte copied to clipboard

SNAP App: support for Thumbstick of the right controller to capture picture and gif in HMD only.

Open AleziaKurdis opened this issue 1 year ago • 1 comments

This PR adds the possibility to click on the thumbstick of the right controller to capture picture and gif, for HMD only.

It was a bit an irritant to capture picture and have to click on the tablet to do it. It is annoying for the posture if you are in the photo and it was quite a limitation to capture in movement.

It supports at least Vive and Oculus Touch.

AleziaKurdis avatar Jul 19 '24 02:07 AleziaKurdis

I think this PR is safe to merge

ksuprynowicz avatar Jul 22 '24 14:07 ksuprynowicz

I tested this on desktop on Linux, both with and without a controller. Works fine in the sense that nothing breaks.

JulianGro avatar Sep 02 '24 11:09 JulianGro

I'm closing this PR.

  • It would have to be redone if we move to openXR.
  • Adding a notice means that we must redo all the UI layout (I tried and it would need significant changed to fit anything on it.)
  • We have currently many camera app. Maybe we could start to consider to merge some concept in a future project. (and they are having the same limitation regarding the controlers.)
  • Everyone was able to live without it before.. I think we can survive until openXr.

AleziaKurdis avatar Oct 02 '24 23:10 AleziaKurdis

Maybe instead of closing we should mark this as work in progress? This feature will be a very nice improvement, especially once we get OpenXR.

ksuprynowicz avatar Oct 03 '24 05:10 ksuprynowicz

I will redo something once openXR will be there.

Also I lived at least one month with this feature... I added it mainly to be able to capture gif sequence while I was in movement, and even if the thumbstick is the closest thing to a real photography trigger, it's not a big deal for that what I aimed to do with it. Cause if we click too deep on it, it literally interrupt the movement... ruining the shot. (it happened to me at least 25% of the time.)

I think it will worth to design a better app instead of having 5 different one. (that will all need refactoring anyway)

And the obligation to get a still image to be able to get a gif... this, i don't get it... why they coded this like that? I supposed there is a technical reason...

AleziaKurdis avatar Oct 04 '24 01:10 AleziaKurdis